search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
44 stars 46 forks source link

plugins: fix undefined references #413

Open orbea opened 3 months ago

orbea commented 3 months ago

Many of the plugins have undefined references, but with GNU libtool it silently ignores the -no-undefined flag so the build succeeds. With slibtool it correctly sets -Wl,--no-undefined in the linker flags causing the build to fail.

Please view the commit messages for more details. The alternative to removing -no-undefined in the last commit is to turn most of mate-settings-daemon into a convenience library and link that into most of the plugins, but that doesn't seem correct.

This was reported for Gentoo: https://bugs.gentoo.org/922326

lukefromdc commented 3 months ago

I simply don't know enough about the build system to properly evaluate this, so leaving it for other team members