search

mate-desktop / mate-system-monitor

Process viewer and system resource monitor for MATE
https://mate-desktop.org
GNU General Public License v2.0
45 stars 27 forks source link

Allow to change the number of columns in the CPU History graph #233

Closed rbuj closed 2 years ago

rbuj commented 2 years ago

By default the number of columns is 4, the minimum is 3 and the maximum is 12.

Test:

gsettings set org.mate.system-monitor num-cpu-columns 5

Screenshot at 2021-12-15 21-19-54

closes #232

mbkma commented 2 years ago

@rbuj build fails on debian, maybe related to gdkmm?

rbuj commented 2 years ago

@mbkma I think so, maybe it needs to be rebuilt using latest gcc. https://github.com/mate-desktop/mate-system-monitor/pull/230#issuecomment-991780460

raveit65 commented 2 years ago

This works as expected with my 8/16 core/thread cpu. But i have definetly a limit of 13 columms with my 28" UHD monitor, to avoid that the GUI is to large for the monitor. So, i am in doubt that this really fix the 128 core workstation/server problem. But ok, 128/13 ~ 10 rows is better that before. Bildschirmfoto zu 2021-12-28 18-40-41

I think we can ignore the debian CI issue, as it builds fine on fedora and it isn't related to this PR.

rbuj commented 2 years ago

Another approach for fixing the linked issue is available at #236

rbuj commented 2 years ago

@raveit65 done, By default the number of columns is 4, the minimum is 3 and the maximum is 12.

raveit65 commented 2 years ago

I guess we can close this PR in favor of the other one?

rbuj commented 2 years ago

done