distcheck-support

[lukefromdc]

Include EXTRA_DIST in makefile.am files for make distcheck

[lukefromdc]

Note that for some reason these files are not actually copied into the tarball yet

[raveit65]

NEWS file is missing. Distcheck needs that for releasing. See other repos.

[lukefromdc]

NEWS is actually present at https://github.com/mate-desktop/mate-wayland-session/blob/master/NEWS but might not be being found

[raveit65]

I did a rebase...

[lukefromdc]

Rebased again after https://github.com/mate-desktop/mate-wayland-session/pull/7/commits/8a8cd182c5fff40863857fcb303b01a9d5c5f2e9

Still no idea how to fix the files not actually being copied for distcheck. My guess is EXTRA_DIST tells autotools to copy them into the tarball but not to copy them into the build directory used for distcheck.

[lukefromdc]

rebased and force-pushed after the /usr/local work

If I could find some good documentation of how to get make distcheck working, I might be able to fix this. Otherwise we might need to look into releasing with meson or however non-autotools packages get released. Hoping to get this out the door in time for distros to pick it up for their Spring updates

[lukefromdc]

What is going on here is that distcheck does a portable build, copying files into another directory but I do NOT know why that doesn't work here and I do not know anything about how to support portable builds in autotools at all. I probably cannot fix this, unsure what to do

[lukefromdc]

Turns out adding $(srcdir)/ to each of the files to be copied fixes the portable build problem, now I just need to get schema compilation moved to someplace that won't be run formake distcheck

[lukefromdc]

At this point, sudo distcheck will complete (needing priviliges for glib-compile-schemas which still gets run), though we get some extraneous files in the tarball

[lukefromdc]

https://stackoverflow.com/questions/40948462/make-distcheck-permission-denied As of now, if I comment out the code for glib-compile-schemas, I can still only get distcheck to conplete as sudo-because distcheck uses permissions to enforce files not being copied to or removed from source directories. Problem is I do NOT understand what i should be doing different with this, not at all. Documentation is very sparse and the answer above I was not able to understand.

[raveit65]

At this point, sudo distcheck will complete (needing priviliges for glib-compile-schemas which still gets run), though we get some extraneous files in the tarball

Using sudo should not be needed for the build dir in normal user account.

[lukefromdc]

Indeed it should not be. I will check out how mate-terminal handles installing the wrapper script, that might tell me what needs to be done to install these files

[lukefromdc]

@cwendling any thoughts on what I am doing wrong here?

[lukefromdc]

I now have make distcheck working properly, used examples from around MATE's other projects to revise how the Makefile.am files actually call for copying everything to methods more easily understood by autotools. We can now build tarballs. One quibble: the makefiles from ./autogen.sh are getting included in the tarballs.

[lukefromdc]

For some reason I have to include

    session \
    data \

in EXTRA_DIST in the toplevel Makefile.am, which is no doubt why the created Makefiles get into the tarball. Merging this and leaving them, as they will be overwritten on configuration by any builder anyway. Open to fixes at any later time, they can go into a point release.

[cwendling]

Sorry I didn't see the ping earlier. I created #11 to improve and simplify things :)

PS: BTW I'm not an owner of this particular repo somehow, so I had to push to a fork… is that expected?

[cwendling]

@cwendling any thoughts on what I am doing wrong here?

See #11, where we can discuss things if you wish more explanations

[lukefromdc]

Not a problem at all, and thanks for the build cleanup! I will apply this when I get back from the road today,

[lukefromdc]

Not being able to push to this repo was entirely unexpected and unintended