mate-desktop / mozo

Menu editor for MATE using the freedesktop.org menu specification
http://www.mate-desktop.org
GNU Lesser General Public License v2.1
28 stars 12 forks source link

Fix deprecation warnings #58

Closed samtygier closed 5 years ago

samtygier commented 5 years ago

Fix 2 warnings when run with PYTHONWARNINGS=d on python 3.7

raveit65 commented 5 years ago

Or rebase against our master :) This will remove the merged commit from PR.

raveit65 commented 5 years ago

@flexiondotorg I think using the rebase+merge button here will exactly do what you requested. You will see that if you run git rebase master in your local repo.

samtygier commented 5 years ago

I force pushed a new branch based on master, with just the 2 commits. Is that ok now?

raveit65 commented 5 years ago

Looks OK https://github.com/mate-desktop/mozo/pull/58.patch

raveit65 commented 5 years ago

Should be reviewed by another person because python isn't my work segment.

yetist commented 5 years ago

Patch is OK, but the PR shoud rebase on the master branch.