search

mate-desktop / mozo

Menu editor for MATE using the freedesktop.org menu specification
http://www.mate-desktop.org
GNU Lesser General Public License v2.1
28 stars 12 forks source link

Add Undo and Redo buttons #62

Closed gm10 closed 5 years ago

gm10 commented 5 years ago

Because currently there are only keybinds. Needs https://github.com/mate-desktop/mozo/pull/61 to fix the undo/redo functions first.

vkareh commented 5 years ago

Looking good so far, could you rebase from master and force-push this?

lukefromdc commented 5 years ago

When I installed this by simply replacing the changed files with these, the undo and redo buttons appeared but undo and redo did not actually work. MainWindow.py and MenuEditor.py are the two files changed in #61 so unless this PR's files did not include those changes this should have worked.

An attempt to rebase on current master failed, so I could not build from that

gm10 commented 5 years ago

@vkareh done.

@lukefromdc no this did not include #61. Usually people prefer PRs that stand on their own (and the buttons technically did, just the functionality itself was shot without #61).

lukefromdc commented 5 years ago

https://github.com/mate-desktop/mozo/pull/61 has been merged to master, so a rebase against master (which I will now test) should actually work completely.

EDIT: looks like last force-push included this rebase