search

mate-desktop / mozo

Menu editor for MATE using the freedesktop.org menu specification
http://www.mate-desktop.org
GNU Lesser General Public License v2.1
28 stars 12 forks source link

Error with PanelDItemEditor on "New Menu" or "New Item" click #81

Closed mbkma closed 3 years ago

mbkma commented 3 years ago

Expected behaviour

Clicking on "New Menu" or "New Item" brings up dialogue to add menu or item respectively.

Actual behaviour

No dialogue appears, instead an error:

(mate-desktop-item-edit:45986): Gtk-CRITICAL **: 10:08:06.255: Unable to load resource for composite template for type 'PanelDItemEditor': The resource at “/org/mate/panel/panel-ditem-editor-dialog.ui” does not exist

Steps to reproduce the behaviour

Open Mozo, click "New Menu" or "New Item" button

MATE general version

all packages compiled from (more or less) recent master

Package version

master

Linux Distribution

manjaro

Link to bugreport of your Distribution (requirement)

it is not distribution specific, but maybe https://github.com/mate-desktop/mate-panel/commit/e9d2e89f5b66574401376c6ef64c856a6cee7f44 is related. Btw creating a custom application launcher with right click on the panel works fine, although it is the same dialogue that should be opened in mozo I think.

lukefromdc commented 3 years ago

I just confirmed this, looks like Mozo is trying to find this UI file from mate-panel, but it is a gresource compiled into mate-panel itself and not a file in the filesystem. This also means mozo would be depending on the mate-panel binary if this was made to work as it stands. I have no idea if one program is even allowed to use a gresource compiled into another program and loaded by it.

I would suggest we copy this file into mozo itself so it can stand alone from mate-panel and from future changes. I am assuming this worked at one point, and silently broke when this part of mate-panel was changed and it didn't occur to anyone to test mozo (and who knows what else) as well as mate-panel with those changes

mbkma commented 3 years ago

Maybe an even better approach would be backporting this commit: https://gitlab.gnome.org/GNOME/alacarte/-/commit/968c81bf5f9d4b8e3c71f33b142b8f77363378f1 which would make mozo independent from mate-panel.

lukefromdc commented 3 years ago

That in fact is probably what will have to be done, unless someone wants to fix the panel dependency and ensure all distros list mate-panel as a dependency of mozo

tim3dman commented 3 years ago

I have these issues as well with Arch Linux (5.13.12.arch1-1) Mate(1.26.0), In the Control Centre, Main Menu - New Menu + New Item are opening up a small blank box and Properties is not responding at all.