mateosss / matter

Customizable GRUB theme inspired by Material Design
Boost Software License 1.0
865 stars 50 forks source link

Matter has too many dependencies #50

Closed bobbbay closed 2 years ago

bobbbay commented 3 years ago

This is a real general issue, and I have no clue where to start to tackle it - but what do you think the chances are somebody will really install mtools, QEMU, grub2-something-something, and a ton more? I like keeping my system light - but I'd also really like to use this. Hence, I'd like to tackle killing off dependencies one by one.

Does anyone have thoughts on how we should start?

bobbbay commented 3 years ago

Current list:

bobbbay commented 3 years ago

Update on grub2-theme-preview:

Pip installs packages either from source or a wheel. Luckily, grub2-theme-preview (further on mentioned as gtp) has both. This means that we could theoretically have a dependencies directory, in which we download and install our dependencies. Furthermore, we could not add gtp to PATH, and call it directly from the script (./dependencies/bin/grub2-theme-preview).

Tar: https://files.pythonhosted.org/packages/ea/82/dff14ee13f20393811f01e036417757e714dbc2fe2293d128166014469a8/grub2-theme-preview-2.0.1.tar.gz

mateosss commented 3 years ago

Hi, thanks for the proposal!

I totally agree about the idea of reducing the dependencies of matter, mainly the inkscape and imagemagick ones. This issue is targeted towards solving those in particular.

About grub2-theme-preview (and therefore QEMU, Mtools, etc), as stated in the readme, it is an optional dependecy, not needed for normal use of Matter but more for people who really want to tinker around with it. Having said that, a lot of questions arise for me:

  1. Do you still think is worth to make matter be the responsible to install grub2-theme-preview and not the user?
  2. Shouldn't this be done first with matter main dependencies like inkscape and imagemagick? But if we do these we will need to support every package manager the user could have: apt, pacman, rpm, guix, etc.
  3. I don't know if matter installing a bunch of megabytes of dependencies by itself will be welcomed by everyone, but I do see how that could be a convenience for many users as well. Nonetheless, the support effort of this feature is my main concern.

What are your thoughts on these?

bobbbay commented 3 years ago

Hey, thanks for getting back!

Would you like to install grub2-theme-preview (mandatory dependency for testing) (20mb) [y/n]

How does that sound?

mateosss commented 3 years ago

Great, the prompt idea sounds more convincing. Go ahead with the feature, and let's smooth things out on the go.

bobbbay commented 2 years ago

Closing because I lost time to work on this and it's not much of an issue :).

mateosss commented 2 years ago

No problem!