material-extensions / vscode-material-icon-theme

Material Design icons for VS Code
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
2.38k stars 669 forks source link

feat: ✨ enhance cloning so two-color icons adhere to same-palette rule #2932

Closed lucas-labs closed 2 months ago

lucas-labs commented 2 months ago

Description

I was working on a migrations folder icon (rel: #895) by cloning the folder-database and this was the result:

Captura de pantalla 2025-03-09 032848

As you can see, the color in the motif path is from the light-blue palette, while the chosen base color was in the blue-gray palette.

I think this issue occurs due to two factors:

Since we are only playing with the hue and luminance values of the colors, the result ends up with a color from the light-blue palette instead of blue-gray.

This PR ensures the saturation of the base color is maintained when selecting the motif color, so the resulting color comes from the same palette as the base color.

image

Contribution Guidelines

github-actions[bot] commented 2 months ago

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.