material-extensions / vscode-material-icon-theme

Material Design icons for VS Code

https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme

MIT License

2.36k stars 668 forks source link

fix(#2956): 🚑 firebase icon not working #2957

Closed lucas-labs closed 1 month ago

lucas-labs commented 1 month ago

Svgo broke the new firebase file icon during release v5.21.0.

The file was quite complex, using transforms and other stuff that svgo probably didn't like. This commit doesn't change the shape, just simplifies the svg markup.

Closes: #2956 Ref: 058ea1c, #2924

Description

Contribution Guidelines

[x] By creating this pull request, I acknowledge that I have read the Contribution Guidelines for this project
[x] I have read the Code Of Conduct and promise to abide by these rules

github-actions[bot] commented 1 month ago

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

github-actions[bot] commented 1 month ago

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

ciriousjoker commented 1 month ago

Sorry for breaking this. I'm pretty sure I originally checked to make sure the svgs work properly, but I probably re-exported them again at the end and I just assumed they would still work instead of checking again. Thanks for the quick fix!

lucas-labs commented 1 month ago

@ciriousjoker don't worry, the svg was a valid svg, but before releasing we run a tool called svgo to optimize it. It was actually svgo who broke the file 😅

ciriousjoker commented 1 month ago

Yes, but I checked and this also happens when running the extension locally, so I should have spotted it.

PKief commented 1 month ago

Yes, but I checked and this also happens when running the extension locally, so I should have spotted it.

Our SVG optimizer tool called SVGO only runs while doing a release: https://github.com/material-extensions/vscode-material-icon-theme/blob/34140dfcf1ea182d4d0b5a0369bafb6dfd363ba1/.github/workflows/release.yml#L45

It's not part of the local build process. You can also execute it locally by running "bun run preversion" to see the actual changes of it. But it's definitely not your fault. It's not required to run this command locally.