search

material-table-core / core

Datatable for React based on material-ui's table with additional features. Support us at https://opencollective.com/material-table-core
https://material-table-core.github.io
MIT License
296 stars 146 forks source link

Wrong type in index.d.ts in release 5.0.3 #580

Closed ckchiu2 closed 2 years ago

ckchiu2 commented 2 years ago

Describe the bug

In 5.0.3 release, the component types are changed to React.ReactNode, and it throws error in typescript. It also does not match with the types declared in master branch.

To Reproduce

https://codesandbox.io/s/gracious-hofstadter-mpxqsv?file=/src/App.tsx

image

You can see typescript is hinting the error for the return type of MTableBodyRow.

I cannot reproduce the compilation error in sandbox though.

Domino987 commented 2 years ago

Yes we were a little bit to free with the replace all. will be fixed next version