search

materialos / CM12-Theme

Material Open Source Cyanogenmod 12/12.1/13 theme
41 stars 15 forks source link

Make sure settings theme works on both CM12 and 13 properly #6

Closed undu closed 8 years ago

undu commented 8 years ago

Most of the icons in the settings screen are not shown: Bluetooth Memory Status Bar

This happens using version 1.0 as well as the git version when using cyanogenmod 13 nightly on a motorola moto g 4g.

It also may be related that system UI crashes whenever I try to get into the Bluetooth screen, when I don't have the theme enabled it gets open just fine.

anuragk47 commented 8 years ago

The settings icons missing on CM13 is a known bug and part of reasons why we don't say the theme works on CM 13.

anuragk47 commented 8 years ago

@undu I will link you to a newer apk soon. Test that and tell me if the settings icons are fine there.

anuragk47 commented 8 years ago

@undu here http://jkcloud.eu/5a012d92b8670c57

anuragk47 commented 8 years ago

@undu also, make a separate issue for the bluetooth crash bug possibly with a log. Also keep hunting and reporting more bugs on CM 13 to help us ensure proper CM 13 support.

undu commented 8 years ago

@Anonymas This apk works fine, it fixed the bluetooth crash too :+1:

undu commented 8 years ago

On the bluetooth settings, the keyboard icon are not themed properly, they don't foloow the same placing nor color as the rest of icons:

Bluetooth settings

anuragk47 commented 8 years ago

@undu Please show a screenshot of the settings app with the new apk(I want to check something). We will add the keyboard icon soon.

undu commented 8 years ago

Have a look: http://imgur.com/a/kL415

anuragk47 commented 8 years ago

Note to self: To close this issue:

  1. Add the keyboard icon
  2. Fix the dividers not being transparent.
anuragk47 commented 8 years ago

@undu okay, btw did you find any more bugs or problems with the theme on CM 13?

undu commented 8 years ago

No, I'll post here if I find anything else.

anuragk47 commented 8 years ago

Much of this is fixed by commit 76ac0db. Now only the keyboard icon and divider to close this issue.

undu commented 8 years ago

I've found that the settings app crashes when trying to open the battery submenu:

12-09 12:10:51.279 12130-12130/com.android.settings D/SubSettings: Launching fragment com.android.settings.fuelgauge.PowerUsageSummary
12-09 12:10:51.411 12130-12130/com.android.settings W/ResourceType: No package identifier when getting value for resource number 0x00000000
12-09 12:10:51.412 12130-12130/com.android.settings D/AndroidRuntime: Shutting down VM
12-09 12:10:51.414 12130-12130/com.android.settings E/AndroidRuntime: FATAL EXCEPTION: main
                                                                      Process: com.android.settings, PID: 12130
                                                                      java.lang.RuntimeException: Unable to resume activity {com.android.settings/com.android.settings.SubSettings}: android.content.res.Resources$NotFoundException: Resource ID #0x0

The rest of the submenus work fine for me.

anuragk47 commented 8 years ago

Okay, this is a critical bug. We must fix this before we can release any new update.

anuragk47 commented 8 years ago

I will just close this issue and make a new one for battery FC. Regarding the keyboard icon that isn't a major bug and will be fixed later.