materialsproject / matbench

Matbench: Benchmarks for materials science property prediction
https://matbench.materialsproject.org
MIT License
124 stars 47 forks source link

installation error with python3.10 #269

Open hspark1212 opened 1 year ago

hspark1212 commented 1 year ago

Hi,

Thank you for developing this great repo.

I have a trouble in installing matbench with python 3.10 using pip install matbench. The error might be occurred due to sklearn==1.0.1. I'm wondering if the fixing version of sklearn can be omitted, for example, sklearn>=1.0.1.

Thank you in advance for your answering.

maykcaldas commented 1 year ago

Apparently, scikit-learn didn't provide a wheel for python3.10 in version 1.0.1. They fixed that on version 1.0.2: https://github.com/scikit-learn/scikit-learn/issues/21511

I also tried pip installing on version 3.8.18 and had a problem while compiling something Cython.Compiler.Errors.CompileError: sklearn/ensemble/_hist_gradient_boosting/splitting.pyx

However, the repo's last version updated the setup.py to make the requirements less restrict. Cloning and installing using the setup.py works fine for me both on python 3.8.18 and 3.10.13

aronwalsh commented 9 months ago

This issue also causes pip install matbench to currently fail on Google Colab notebooks.

While pip install git+https://github.com/materialsproject/matbench.git does work, a new release to update PyPy would be appreciated 🙏

AndrewFalkowski commented 6 months ago

Even with that fix, there are dependency issues on import: ContextualVersionConflict: (scikit-learn 1.2.2 (/usr/local/lib/python3.10/dist-packages), Requirement.parse('scikit-learn~=1.3'), {'matminer'})