search

mateusfccp / update_available

Know if there's any update for your Flutter app, based on published versions.
MIT License
25 stars 16 forks source link

Update package_info_plus to 3.0.1 #15

Closed otopba closed 1 year ago

mateusfccp commented 2 years ago

Hello, @otopba.

I am failing to understand what this PR does. It includes a lot of formatting changes, which is making hard to know what has indeed changed or not.

Could you clean this PR so that it respects the current code formatting configuration?

Also, could you provide more information regarding what does this PR proposes? It seems that it's related to Flutter 3.0, but this plugin should work fine with Flutter 3.0. Did you find any issue using it with Flutter 3.0?

Thanks!

otopba commented 2 years ago

Hello! In this PR I updated all the dependencies and cleaned up the project =) Applied code style

mateusfccp commented 2 years ago

I don't think the code style changes are necessary. I will kindly ask you to revert them. IMO, the current formatting is better, and it did not cause any issues with pana nor anything.

otopba commented 2 years ago

@mateusfccp

Hi! I really went a little overboard with the changes. Actually, all I had to do was upgrade package_info_plus to 3.0.1

kuhnroyal commented 1 year ago

Can we get this merged and released? This should build after https://github.com/mateusfccp/update_available/pull/19 is merged and then maybe it can be released.

mateusfccp commented 1 year ago

I am going to give some attention to the issues and PRs when my vacations start, which is 15/Dec.

mateusfccp commented 1 year ago

@otopba Could you rebase to the latest master? Now that #19 is merged we should not have any problem in the checks.

otopba commented 1 year ago

@mateusfccp fixed