search

mathetake / envoy-dynamic-modules

the custom Envoy proxy with dynamic module HTTP filters
Apache License 2.0
12 stars 4 forks source link

Make HeaderValue properties public #27

Closed jonfriesen closed 1 month ago

jonfriesen commented 1 month ago

Hi @mathetake

Would it be possible to make the properties of HeaderValue public?

I'm implementing a Go host side of the ABI spec and this is blocking me from implementing the RequestHeaders and ResponseHeaders interfaces.

I realize that you're still early on this and it might change. We're willing to adapt, this is just a blocker right now.

Thanks!

mathetake commented 1 month ago

I guessed this is essentially what you wanted https://github.com/mathetake/envoy-dynamic-modules/commit/b2cd707ee827c92a4f41aea519e1904070164bbd does this work for you now?

jonfriesen commented 1 month ago

That's perfect! Thanks for the insanely quick turn around. Have an awseome weekend! 🎉

mathetake commented 1 month ago

you too! 💯