search

mathieucarbou / ESPAsyncWebServer

Asynchronous HTTP and WebSocket Server Library for ESP32, ESP8266 and RP2040
https://mathieu.carbou.me/ESPAsyncWebServer/
GNU Lesser General Public License v3.0
83 stars 17 forks source link

(perf) std::list => std::vector #99

Closed mathieucarbou closed 2 months ago

mathieucarbou commented 2 months ago

@vortigont : would you be able to look at this pr please ? I think slowing down removal of handlers and rewrites to decrease memory used for each item is acceptable. There are not a lot of removal of rewrites and handlers in an app.

vortigont commented 2 months ago

Hey @mathieucarbou! Was quite busy lately, mostly skipped lot's of your latest work. Pls, give me a day or two to check on this carefully. Tnx!

vortigont commented 2 months ago

Hey @mathieucarbou! Pls see my comments inline. Will try to suggest some ideas on weekend, still busy with main job :(

mathieucarbou commented 2 months ago

Hey @mathieucarbou! Pls see my comments inline. Will try to suggest some ideas on weekend, still busy with main job :(

no problem. i am still testing the middleware PR. Note: I don't see your comment, but don't worry, I'll wait.

mathieucarbou commented 2 months ago

@vortigont : ok thanks ! I will close the PR then :-) let's revisit that later. Thanks!

vortigont commented 2 months ago

maybe split it into different smaller tasks would be easier to implement/discuss

mathieucarbou commented 2 months ago

maybe split it into different smaller tasks would be easier to implement/discuss

What do you have in mind ?

Do you mean have a project board where we could list some tasks to improve the project?

mathieucarbou commented 2 months ago

I've created a kanban board: https://github.com/mathieucarbou/ESPAsyncWebServer/projects?query=is%3Aopen