search

mathurinm / celer

Fast solver for L1-type problems: Lasso, sparse Logisitic regression, Group Lasso, weighted Lasso, Multitask Lasso, etc.
https://mathurinm.github.io/celer/
BSD 3-Clause "New" or "Revised" License
198 stars 32 forks source link

[READY] REL - remove matplotlib and seaborn dependencies #261

Closed Badr-MOUFAD closed 2 years ago

Badr-MOUFAD commented 2 years ago

This aims to make PyPI installation faster through

codecov-commenter commented 2 years ago

Codecov Report

Merging #261 (cc35cc5) into main (75e3a4c) will increase coverage by 0.17%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   88.44%   88.62%   +0.17%     
==========================================
  Files          15       15              
  Lines        1134     1134              
  Branches      136      136              
==========================================
+ Hits         1003     1005       +2     
+ Misses        101       99       -2     
  Partials       30       30
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celer/tests/test_docstring_parameters.py 75.00% <0.00%> (+1.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75e3a4c...cc35cc5. Read the comment docs.

mathurinm commented 2 years ago

Closing as we have released wheels in another issue, and removing matplotlib and seaborn will break configure_plt() so we'd need a deprecation cycle if we go this way.