matiasdelellis / facerecognition

Nextcloud app that implement a basic facial recognition system.
GNU Affero General Public License v3.0
510 stars 46 forks source link

Renaming person from Photo viewer affects entire cluster and not single photo! #557

Closed diyoyo closed 2 years ago

diyoyo commented 2 years ago

Hey, Thanks for reporting issues back to Nextcloud Face Recognition. Please, try to complete this report in detail so we can help you easier. :smile:

Make sure you read all the documentation, and the FAQ, and that the issue has not been reported before. :wink:

Expected behaviour

When looking at an individual photo, if I change the name on the assigned face, I want only this photo to be reassigned to the new/other person

Actual behaviour

Instead, it renames the entire cluster in which the current pic belonged. The worst part is that if the other person is existing, then it will merge the entire person's picset with the other person's.

Steps to reproduce

  1. Tag two different clusters with two different people
  2. select one picture of the first person in the photo metadata viewer and edit the person's name
  3. Enter the second person's name and Hit "rename"
  4. Go check your new face organization in the settings

Server configuration

Client configuration

Logs

Background task log with debug.

sudo -u apache php occ -vvv face:background_job ``` Insert your background log here ```

Web server error log

Web server error log ``` Insert your webserver log here ```

Nextcloud log (data/nextcloud.log)

Nextcloud log ``` Insert your Nextcloud log here ```

Browser log

Browser log ``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```
guystreeter commented 2 years ago

The sidebar has 2 buttons by each name: Rename person and This person is wrong Rename person will change that person's name everywhere. This person is wrong will take that face out of the cluster. You can give that face a new name at the same time.