TypeError when setting model

RobMahn commented 2 years ago

Expected behaviour

Set Face Recognition Mode

Actual behaviour

An unhandled exception has been thrown: TypeError: OCA\FaceRecognition\Command\SetupCommand::setupModel(): Argument #1 ($modelId) must be of type int, string given, called in /var/www/nextcloud/apps/facerecognition/lib/Command/SetupCommand.php on line 102 and defined in /var/www/nextcloud/apps/facerecognition/lib/Command/SetupCommand.php:138

Steps to reproduce

sudo -u www-data php occ face:setup -m MODEL_ID # or ./occ face:setup --model 2

Assumption

Something in my installation enabled strict mode typing.

Fix

Edit SetupCommand.php line 100 to convert the model to int. $modelId = intval($input->getOption('model'));

Server configuration

Operating system: Debian GNU/Linux 11 (bullseye)
Pdlib version: pdlib extension version | 1.0.2 dlib library version | 19.23.99
How is DLib installed: Make sure it is working correctly with this tool "The hard way" - compiled
How is PDlib installed: Make sure it is working correctly with this tool "The hard way" - compiled
PHP version: PHP Version 8.0.16
Web server: nginx version: nginx/1.18.0
Database: Server version 10.5.12-MariaDB-0+deb11u1
Nextcloud version: 23.0.2.1

matiasdelellis commented 2 years ago

I'm going to see it.. 🤔

Thank you.. and sorry for the delay in answering..

derekakelly commented 2 years ago

I can confirm this issue happened to me as well. Changing the line mentioned above allowed me to install the default model. Looks like it's starting to scan my files now. Thanks!

Ubuntu 22.04 NC 24 PHP 8.1

matiasdelellis / facerecognition