Provide autocomplete of existing persons while manual tagging faces on images

lippoliv commented 1 year ago

Hey, Thanks for reporting issues back to Nextcloud Face Recognition. Please, try to complete this report in detail so we can help you easier. :smile:

Make sure you read all the documentation, and the FAQ, and that the issue has not been reported before. :wink:

Expected behaviour

On images in the "faces" tab of the sidebar, I see who is tagged on the image. For faces who are recognized, but not named yet, I can add a name.

I should be able to select existing persons, beside creating new ones on the fly.

Actual behaviour

I cannot select existing persons, I can just create new ones.

Steps to reproduce

Open an image with an recognized face, which is not connected to a person
Type in the name of an existing person

Server configuration

Operating system: Docker nextcloud:25.0.4-apache

Pdlib version:

ARG DLIB_BRANCH=v19.24
ARG PDLIB_BRANCH=master

How is DLib installed: Make sure it is working correctly with this tool
How is PDlib installed: Make sure it is working correctly with this tool
PHP version: PHP 8.1.16
Web server: Apache
Database: Docker mariadb:10.5
Nextcloud version: 25.0.4

Client configuration

Browser: Tested in Brave and Edge
Operating system: Windows 10

Logs

Background task log with debug.

sudo -u apache php occ -vvv face:background_job

``` unrelated ```

Web server error log

``` none ```

Nextcloud log (data/nextcloud.log)

Nextcloud log

``` none ```

Browser log

``` none ```

matiasdelellis commented 1 year ago

Hi @lippoliv Unfortunately this is a regression forced by a change in nextcloud 25.. (The side panel retains focus, and we can't focus on the dialog we use to search for people.)

I would like to solve it soon. Thank you very much for reporting it.

lippoliv commented 1 year ago

Memories has implemented something like that, maybe not 100% what I described. But basically listen to the input and show some suggestions: https://github.com/pulsejet/memories/issues/177

Maybe instead of a text field, we can open a dialog, if the user clicks on the "unknown face". Then we could let him select a existing face or create a new one?

In that dialog, we could probably (haven't reviewed source code yet) show most similar faces? That would be a quiet nice feature I gues.

matiasdelellis / facerecognition