search

matinlotfali / KDE-Rounded-Corners

Rounds the corners of your windows in KDE Plasma 5 and 6
GNU General Public License v3.0
641 stars 22 forks source link

rounded corners + fractional scaling +steam = kwin crash #240

Closed GloriousEggroll closed 5 months ago

GloriousEggroll commented 5 months ago

If I enable rounded corners then set the scaling to one of my monitors to 150% and open steam it hard crashes kwin. If i set it back to 100 then open steam again it works.

matinlotfali commented 5 months ago

Sorry, but I can't reproduce this on my end. Please provide more information such as your display manager, distribution, and debug logs (rebuild with cmake .. -DCMAKE_BUILD_TYPE=debug and using the sh ../tools/show-kwin-logs.sh

GloriousEggroll commented 5 months ago

Nobara Linux 40 SDDM KDE 6.0.5

Log attached: kwin_log.txt

Note: version says 0.6.5 but I also tried on 0.6.6 with the same problem.

GloriousEggroll commented 5 months ago

Just in case, here's an updated log from 0.6.6:

kwin_log.txt

matinlotfali commented 5 months ago

Looks like it crashes in ShapeCorners::Effect::checkTiled. I will dig more.

https://github.com/matinlotfali/KDE-Rounded-Corners/blob/0e1fa34bb0aa33bc924524531c3b8248ddebaf83/src/Effect.cpp#L226-L260

matinlotfali commented 5 months ago

@GloriousEggroll I need your help to see if #241 fixes your issue. Can you test it for me?

GloriousEggroll commented 5 months ago

no unfortunately that made it worse. it started repeating kwin crashing every 10 seconds or so even without steam open after applying that patch

matinlotfali commented 5 months ago

I want to narrow it down to make sure I am looking at the right faulty piece of code. I guess when having both "Disable Rounded Tiled" and "Disable Outline Tiled" doesn't cause the crash. Can you confirm?

matinlotfali commented 5 months ago

I just updated the PR so there would be a hard limit on the recursion depth. (I mean if that is the issue) I still need @GloriousEggroll to test it.

GloriousEggroll commented 5 months ago

Disable Rounded Tiled and Disable Outline Tiled are both enabled and have been when I get the crash.

The good news is with the latest 241 it's not crashing any more.

The bad news is now it's impossible to drag a window. It goes at a snails pace/repeatedly stutters when trying to do so.

GloriousEggroll commented 5 months ago

eh it seems the window dragging issue was a problem even before the patch so that may be unrelated.

-edit-

upgraded again to new patched build and reenabled and now drag is working fine. sigh. idk at least the patch 241 is working. kwin+steam no longer crashing with fractional scaling.

matinlotfali commented 5 months ago

Great! Lets discuss the dragging in another new issue