Yeah we could at least say parameters should be mdl.Parameters where mdl = bert(...). We don't mention this in the readme either.
Of course you could create parameters from scratch too, but I never added a handy function to do that. And the FinBERT parameters should work too (see finbert.model is just a simple wrapper to bert.model). So I'd want to somehow say using mdl=bert(...) is sufficient but not necessary.
Yeah we could at least say
parameters
should bemdl.Parameters
wheremdl = bert(...)
. We don't mention this in the readme either.Of course you could create
parameters
from scratch too, but I never added a handy function to do that. And the FinBERT parameters should work too (seefinbert.model
is just a simple wrapper tobert.model
). So I'd want to somehow say usingmdl=bert(...)
is sufficient but not necessary.