search

matmair / brother_ql-inventree

Python package for the raster language protocol of the Brother QL series label printers
GNU General Public License v3.0
26 stars 10 forks source link

Reformat and lint the codebase #51

Closed vulpes2 closed 3 months ago

vulpes2 commented 3 months ago

Thank you for taking the time to fork and maintain brother_ql, it's really a shame that the original repo was abandoned. I'd like to clean up the codebase a little and improve the docs in the near future, but it's kind of hard to work with a codebase that is full of linter errors. While this doesn't really get rid of all the linter issues, it's still a good starting point in my opinion.

matmair commented 3 months ago

hi there @vulpes2 ! I really appreciate the PR and ruff in general. My goal for this fork is to reconcile it with upstream once the maintainer of the original repo re-appears. In the meantime, I also pull PRs that are targeted towards upstream from time to time.

Therefore I will not merge this PR as it makes both nearly impossible in an efficient manner due to the large diff created by tools like ruff or black. Hopefully, you understand my reasoning here. My sole focus is not a rewrite but a continuation.

I welcome PRs that address open issues here or in the upstream repo but would ask for a short discussion before time is spent developing features that I will not merge.