Migrate to Swift

[mattiaslevin]

Rewrite the SDK in Swift.

[Erulezz]

+1

Would really like to see this.

[ghost]

+1

that would be awesome!

[mattiaslevin]

Ok, I will start on a Swift implementation. If anyone care to help out please let me know.

[Erulezz]

If you need help with features or testing let me know! I'm migrating a lot of apps to Swift and it would be awesome if everything in my projects is written in Swift.

[funky-monkey]

+10

[mattiaslevin]

ok ok, I have started and have something, lets see if I can get it to a shareable state.

[Urkman]

What is the status here? How can I use Piwik in my Swift Project?

[Erulezz]

You can use this Objective-C project in a Swift project with a bridging header. More info;

https://developer.apple.com/library/ios/documentation/Swift/Conceptual/BuildingCocoaApps/MixandMatch.html

[perlguy99]

I'd love to see this too. How far along are you? Need any help? I may be able to help with it, if needed.

[mattab]

Hi @perlguy99 @Erulezz @Urkman @funky-monkey - your help would be very welcome! @mattiaslevin is very busy at the moment and we would welcome new maintainers and help for the official Piwik iOS SDK :+1: if you are interested please consider opening pull requests. We could also give you commit access once you have contributed some things :-) Thank you for your consideration!

[mattab]

FYI: we the Piwik team are looking for a maintainer for the iOS SDK. if you can help please comment here #91 - we need you!

[JekaNaloyko]

I'll need to refactor the SDK to Swift, as I don't want to use AFNetworking. Already using Alamofire. Will comment here after prototyping the approach.

[jpapay]

Hi @mattab what's up about the Swift portage for piwik ?

[mattab]

@SteamGorilla we are still looking for a volunteer to step up and take over the Piwik iOS SDK project. Would anyone be interested?

It's a unique opportunity to help and participate in a successful open source project and make a difference. We posted on twitter recently asking for help:

[jpapay]

@mattab Okay, thanks for your answer. I'm not already skilled enough to realize a portage by myself :/

[mattab]

Hi everyone, great news: @brototyp is working on a Swift 3 port of the iOS SDK. Please check it here: #96 and report your feedback to help him on his mission. The future of the Piwik iOS SDK is here!

[brototyp]

After the first feedback by @mattiaslevin I realized that the pull request is by far to huge. So I will try to chunk if off into reviewable parts.

First will be a pull request with most objc files removed, new target setup and other project settings. Following pull requests will be separated parts. For example event queuing, dispatching, persisting settings and such.

I am looking forward to any feedback on my plan or, of cause, the pull requests.

[brototyp]

I got the first pull request prepared with just project setup over here: #97

[brototyp]

Since we now have a base branch for the swift3 rewrite I will start a list of all things to write in swift so single parts can be picked and implemented separately. One might be inspired by the ideas over in #96

• Constants: A collection of all constants. API, Userdefaults, parameters, ...
• UserDefaults: A wrapper onto NSUserDefaults that holds all stored values (except events) such as totalNumberOfVisits, firstVisit and such. #101
• UIDevice-Extension: An extension to return the device platform (iPhone1,1), platform name (iPhone 1G), screen size and version of the operating system. #102
• UIApplication-Extension: An extension to return application specific values such as name, version, build version and such #103
• Models for Event, Campaign, Transaction and CustomVariable
• Protocol for an EventQueue
• Protocol for a Dispatcher
• PiwikTrackedViewController
• the PiwikTracker itself

I guess separate tickets for each of those is the best idea. What do you think? @thorstenstark is there any of those you want to tackle?

[thorstenstark]

Yes, I would agree on this. Perhaps it would make sense to split the last two into seperate tickets. I haven't looked into the current implementation of them, but it sound like these two could be a bit more complex... I would start with some low hanging fruits like the extensions of Device and Application to become acquainted with this project.

[brototyp]

The PiwikTrackedViewController is actually very short. It just tracks on viewDidAppear:. For all those points I am very open to splitting them up into smaller chunks. That goes especially for the PiwikTracker but the Dispatcher and the EventQueue can get big.

[brototyp]

Hi, thank you for your Pull Request. We dropped ongoing development for version 3 of this SDK. Please consider looking into version 4, which is completely rewritten in Swift.