search

matomo-org / matomo

Empowering People Ethically with the leading open source alternative to Google Analytics that gives you full control over your data. Matomo lets you easily collect data from websites & apps and visualise this data and extract insights. Privacy is built-in. Liberating Web Analytics. Star us on Github? +1. And we love Pull Requests!
https://matomo.org/
GNU General Public License v3.0
19.94k stars 2.66k forks source link

Improve messaging around plugins compatibility when upgrading to Matomo 5 #21842

Open atom-box opened 10 months ago

atom-box commented 10 months ago

I have had five emails from users who will stay on Matomo 4, rather than update to Matomo 5. They are being scared off by this message in their browser. They interpret this message to mean that they should wait, because Matomo has not yet made new versions of these 13 Premium Features.

Here is what they see before updating:


"Note: some plugins are not compatible with Matomo 5.0.1. We will update them if there is an update on the Marketplace, otherwise we will disable them when you upgrade:

CustomAlerts
CustomReports
CustomVariables
FormAnalytics
Funnels
GoogleAnalyticsImporter
HeatmapSessionRecording
MarketingCampaignsReporting
MultiChannelConversionAttribution
Provider
RollUpReporting
SecurityInfo
UsersFlow"

Proposed edit, to make the message less threatening:

"Note: We encourage you to update to Matomo 5.0.1. The following plugins will be disabled during the upgrade and you will need to re-enable them.:

CustomAlerts CustomReports CustomVariables FormAnalytics Funnels GoogleAnalyticsImporter HeatmapSessionRecording MarketingCampaignsReporting MultiChannelConversionAttribution Provider RollUpReporting SecurityInfo UsersFlow"

atom-box commented 10 months ago

Or is this list a bug? Are these listed plugins appearing as a false positive?

atom-box commented 10 months ago

Richard suggested this wording:

"Matomo will attempt to update the following plugins during/after the update to 5.x"

atom-box commented 10 months ago

image

atom-box commented 10 months ago

Matthieu commented in Slack#Support:

It looks like a bug in Matomo (why would it say that when we could actually check and only list the ones that are not yet compatible?)

Stan-vw commented 10 months ago

As per @snake14 's message in https://github.com/matomo-org/matomo/issues/21811 (see https://github.com/matomo-org/matomo/issues/21811#issuecomment-1904778359), these plugins are in fact Matomo 5 ready.

Keen to understand if we can simply adjust the message (or delete it). My main consideration is that we don't delete it or adjust it in a way that gives problems for future updates. I imagine the current message was implemented for a reason, and it does certain checks leading to this message

sgiehl commented 10 months ago

We can't simply remove it. What we would need to do is automatically checking for compatible versions on the marketplace and splitting that message into two parts. So you have one part listing the plugins where a new version is available and an automatic update will be done (if possible) and a second part that lists the plugins where no compatible version is available.

BloodyIron commented 10 months ago

PLEASE DO NOT REMOVE THIS!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

The reason this function is important to me is to know if an upgrade will BREAK what I care about. If there are false positives, THAT is what needs to be fixed, NOT REMOVING THIS! The last thing I want to do is have to revert an upgrade just because I wasn't told beforehand that (a) plugin(s) I care about are not compatible, breaking usability.

The scary language being scary has value.

michalkleiner commented 10 months ago

Stefan's suggestion makes the most sense. It is likely we are overly cautious and some plugins do have compatible versions and can be updated automatically, some still might not be compatible and we need to warn about those.

Doing extra set of checks and splitting the list in two sounds like a good enhancement.

Passing to the product team for prioritisation.