Remove unused "data" request parameter

matomo-org / piwik-dotnet-tracker

C# API client SDK for the Piwik Tracking API

BSD 3-Clause "New" or "Revised" License

74 stars 47 forks source link

Remove unused "data" request parameter #38

Closed julienmoumne closed 7 years ago

julienmoumne commented 7 years ago

Mentioned by @ptr1120 in https://github.com/piwik/piwik-dotnet-tracker/pull/36.

We should provide a way to set the value.

mattab commented 7 years ago

As you have already implemented setCustomTrackingParameter in the C# sdk, it should be possible to use this method to define a custom data parameter. Since data is not a supported tracking api parameter, maybe this is not really needed?

julienmoumne commented 7 years ago

Fixed in https://github.com/piwik/piwik-dotnet-tracker/commit/642061fe890833c6b0407a7e74e3caf590ae1957