search

matplotlib / matplotblog

Matplotlib blog
https://matplotlib.org/matplotblog/
37 stars 39 forks source link

Fix MVP multiplication #20

Closed eitanlees closed 4 years ago

eitanlees commented 4 years ago

I've been reviewing some older posts. I very much enjoyed this one on creating a custom 3D engine but I found an error in the final code chunk.

The MVP matrix should be built by multiplying on the left.

This is done correctly in the linked example bunny-8.py but not in the posted example.

cc @rougier

davidevaleriani commented 4 years ago

Thanks for spotting this!