search

matrix-org / matrix-conf-website

Other
0 stars 6 forks source link

Improve the flow of the spacing on the watch cards using a whole bunch of nested (not subgrid) grids #71

Open MTRNord opened 3 weeks ago

MTRNord commented 3 weeks ago

grafik

This is not perfect either but it seems to have better text flow than whats on main now that I had to untruncate the headers since those hid valuable information.

kinda helps #70 ?

cc review from @HarHarLinks appreciated (cant do it via github itself :|)

cloudflare-workers-and-pages[bot] commented 3 weeks ago

Deploying matrix-2024 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 96ba666
Status: ✅  Deploy successful!
Preview URL: https://0ea045e5.matrix-2024.pages.dev
Branch Preview URL: https://mtrnord-a-bunch-off-grids.matrix-2024.pages.dev

View logs

MTRNord commented 3 weeks ago

The result is clearly an improvement, I don't see any new issues with it.

Its a bit strange that this whitespace is not collapsing: image

In a perfect world, in these situations, the description on the right would continue to fill the whitespace caused by the 3 line title on the left image

Yeah I tried it but it seems like without javascript it's not possible. The css can either add the dots at the very end of the content and then does not respect if the overflow is cut off (so in these cases it wouldnt work) or it can do it after a specific number of lines (we do 3 here). Sadly there seems to be no way for a best of both Worlds with pure css and html :/

HarHarLinks commented 3 weeks ago

The mobile version improved compared to main. The right margin is missing here: image