search

matrix-org / matrix-spec

The Matrix protocol specification
Apache License 2.0
197 stars 97 forks source link

Reuse Invite3pid object across spec #1955

Open td-famedly opened 2 months ago

td-famedly commented 2 months ago

Link to problem area:

object: https://github.com/matrix-org/matrix-spec/blob/938022b1ff671e6c862b3d71cf8c3c470ef40f90/data/api/client-server/create_room.yaml#L135

Could be reused here f.ex: https://github.com/matrix-org/matrix-spec/blob/938022b1ff671e6c862b3d71cf8c3c470ef40f90/data/api/client-server/third_party_membership.yaml#L86

There could be other places we could reuse this at too

richvdh commented 1 month ago

We're always very happy to receive PRs for this sort of thing!

richvdh commented 1 month ago

(are you proposing a change to how the spec text is displayed? or would this just be a change to the OpenAPI objects?)

td-famedly commented 1 month ago

The latter, the issue is so that I don't forget to create a PR later or maybe someone else would also like to pick this up befor that :D