search

matrix-org / waterfall

A cascading stream forwarding unit for scalable, distributed voice and video conferencing over Matrix
Apache License 2.0
98 stars 5 forks source link

subscription: change the warning message #137

Closed daniel-abramov closed 1 year ago

daniel-abramov commented 1 year ago

This message seems to happen primarily when the video is muted, but seldomly in other cases that are yet to be discovered.

Printint the warning in the logs does not make any sense as our logs end up being filled up with such messages. One could implement a reaction to this message in a way that we'll stop the given subscription if it's stalled (whether for mute reason [video]) or for any other reason.

But this means that the SFU will actively unsubscribe the client from the subscriptions that appear dead for the SFU. The question is if such behavior is something that the EC is ready for? Since currently we don't have a mechanism to inform the EC for the changes (well, we could remove the track that will possibly cause a renegotiation, but that's it).

@SimonBrandner do you know how the EC would behave if one of the subscriptions gets closed by the server? Will the EC try to re-request it if necessary? (if so, I could implement the logic on the SFU side to remove stalled subscriptions and remove the corresponding tracks from the peer connection that they are related to)

Relates to https://github.com/matrix-org/waterfall/issues/121

SimonBrandner commented 1 year ago

@SimonBrandner do you know how the EC would behave if one of the subscriptions gets closed by the server? Will the EC try to re-request it if necessary? (if so, I could implement the logic on the SFU side to remove stalled subscriptions and remove the corresponding tracks from the peer connection that they are related to)

Yeah,it would end-up requesting it eventually due to window resizing etc. but there is no clear logic for it atm