matrixorigin / matrixone

Hyperconverged cloud-edge native database
https://docs.matrixorigin.cn/en
Apache License 2.0
1.79k stars 276 forks source link

[Bug]: Load data from aliyun panic if the parameters are incorrect. #12194

Closed Ariznawlll closed 1 year ago

Ariznawlll commented 1 year ago

Is there an existing issue for the same bug?

Environment

- Version or commit-id (e.g. v0.1.0 or 8b23a93): fade9c43805334a358b017daf62dde891ef1c89d
- Hardware parameters:
- OS type:
- Others:

Actual Behavior

image

Expected Behavior

No response

Steps to Reproduce

Load data from aliyun:

sql:load data url s3option {"provider"='aliyun', "endpoint"='oss-cn-shanghai.aliyuncs.com', "bucket"='lr90-bucket', "filepath"='customer.csv', "role_arn"='***',"provider"='minio',"compression"='auto'} into table customer  FIELDS TERMINATED BY '|' ENCLOSED BY '\"' LINES TERMINATED BY '\n';

Additional information

No response

aylei commented 1 year ago

@reusee PTAL

reusee commented 1 year ago

This nil pointer deref issue was fixed in https://github.com/matrixorigin/matrixone/commit/0070abe134880d9b12e8b4108647a9ebd42fb7aa#diff-53c458acf1a3339cd979fff55fe0f53e01073eadae1e21b997ff1933461b6539R562

I don't think the reported commit id is correct, since the 527 line of aliyun_sdk.go does not contain any pointer deref https://github.com/matrixorigin/matrixone/blob/fade9c43805334a358b017daf62dde891ef1c89d/pkg/fileservice/aliyun_sdk.go#L527

Ariznawlll commented 1 year ago
image

Verifeid!

reusee commented 1 year ago

OK, re-assigning