search

matsen / pplacer

Phylogenetic placement and downstream analysis
http://matsen.fredhutch.org/pplacer/
GNU General Public License v3.0
75 stars 18 forks source link

batteries.2.0.0 installation fails #320

Closed nhoffman closed 11 years ago

nhoffman commented 11 years ago

With a fresh build of opam and the ocaml compiler, batteries.2.0.0 fails to install:

[ERROR] Version 2.0.0 of "batteries" is not available for your compiler or your OS.
'/home/nhoffman/src/yapp/yapp-env/bin/opam install --root /home/nhoffman/src/yapp/yapp-env/share/opam -y batteries.2.0.0' failed.

opam 1.1.0, compiler 4.01.0, ubuntu 12.04 (this is on stoat)

If I replace "batteries.2.0.0" with "batteries", installation of batteries.2.1.0 works fine, and pplacer seems to compile successfully (and runs in limited tests)

cmccoy commented 11 years ago

Hi Noah,

We've only tested on OCaml 3.12.1 - I'd recommend compiling pplacer against that.

I have no objection to batteries 2.1.0, either; based on the changelog, it seems unlikely to cause any issues.

Connor

nhoffman commented 11 years ago

Thanks, Connor - I can confirm that batteries 2.0.0 compiles using OCaml 3.12.1 - it may be worth being more explicit in the pplacer compilation instructions, because installing the opam binaries as described in http://opam.ocaml.org/doc/Quick_Install.html provides 4.01.0 by default (this is specified in http://www.ocamlpro.com/pub/opam_installer.sh). Might also be worth bumping batteries to 2.1.0 in the requirements file if it doesn't hurt to avoid the error using the default version of the compiler. Thanks!

cmccoy commented 11 years ago

Glad to hear it worked.

I raised issues to update the docs (#321) and possibly move to Batteries 2.1 (#322).