dms_variants --> binarymap

wsdewitt commented 3 years ago

Description

Trade deprecated dms_variants dependency to new standalone binarymap package.

Tests

No additional tests

Checklist:

[ ] The code uses informative and accurate variable and function names
[ ] The functionality is factored out into functions and methods with logical interfaces
[ ] Comments are up to date, document intent, and there are no commented-out code blocks
[ ] Commenting and/or documentation is sufficient for others to be able to understand intent and implementation
[ ] TODOs have been eliminated from the code
[ ] The corresponding issue number (e.g. #278) has been searched for in the code to find relevant notes
[ ] Documentation has been redeployed

jgallowa07 commented 3 years ago

@WSDeWitt Actually, after inspecting the build failure, here. Maybe you should update the requirements file or update the makefile to ignore the dev requirements. The dev requirements could also be put into the setup config using the extras_require parameter. in setup.py

wsdewitt commented 3 years ago

It looks like the build failure is caused by binarymap requiring Python 3.8, so I think we need our setup.py to say python_requires=">=3.8", also our CI workflow should use 3.8.

matsengrp / torchdms