search

mattbanks / dotfiles-syntax-highlighting-st2

User settings to bring ShellScript (Bash) syntax highlighting to dotfiles
211 stars 28 forks source link

Not working with Sublime Text 3 #42

Open rhhamburg opened 5 years ago

rhhamburg commented 5 years ago

The current version will not work with Sublime Text Build 3176 on macOS Mojave 10.14.3 😞.

mattbanks commented 5 years ago

@rhhamburg I'll try to take a look in the next week. I don't have ST3 installed anymore (I've switched to Visual Studio Code), so I'll have to download it and get it spun up. I haven't been following ST3 development, so I'm not sure if anything changed with how plugins work.

tsyroid commented 5 years ago

Confirmed: ST3 Build 3208 Mojave 10.14.6 Sure would love this plugin :-) TIA Any way to manually drop this in somehow?

0xdevalias commented 4 years ago

So I made a test file foo.sh in ST3, which by default uses the 'Bourne Again Shell (Bash)' syntax

image

We can use 'Open all with current extension as...' to manually tell ST3 to use the specified syntax for all files with a matching extension image

We can override syntax specific settings with the Sublime Text -> Preferences -> Settings - Syntax specific (macOS) menu item (ref: StackOverflow)

image

This opens the Bash.sublime-settings file in your ST3 directory

image

Which as you can see in the screenshot, has the syntax required for the override we just created:

{
  "extensions":
  [
    "foo"
  ]
}

So I expect the reason this package doesn't work in ST3 currently is that it customizes the wrong file for ST3 to pick it up, and uses slightly different syntax.

@mattbanks as you mentioned in https://github.com/mattbanks/dotfiles-syntax-highlighting-st2/issues/42#issuecomment-472655357 that you don't really use ST anymore, I was wondering if you would consider transferring control of this package? I would be happy to take over maintaining it, either directly under my own GitHub, or under a GitHub organisation so that it is 'namespaced', and multiple maintainers/related packages could be scoped to it.

ThomasHineXYZ commented 3 years ago

This is still not working on Sublime Text 4

@mattbanks as you mentioned in #42 (comment) that you don't really use ST anymore, I was wondering if you would consider transferring control of this package? I would be happy to take over maintaining it, either directly under my own GitHub, or under a GitHub organisation so that it is 'namespaced', and multiple maintainers/related packages could be scoped to it.

@0xdevalias That might be a good idea if @mattbanks doesn't want to maintain this anymore.

mattbanks commented 3 years ago

I would be happy to transfer this over if someone is interested in maintaining. I think creating an org would be best to have it namespaces and allow multiple code owners going forward.

As I haven't used ST in a very long time. I can't say for sure how transferring the repo will affect the package URL for search/downloads, so I want to call that out for whoever is taking it over. @0xdevalias if you want to create a namespaced org for this, we can transfer the repo over.

Lilac-Orange commented 3 weeks ago

I would love to continue the development.