mattbierner / vscode-emojisense

Emoji Autocomplete Plugin For VSCode
https://marketplace.visualstudio.com/items?itemName=bierner.emojisense
MIT License
123 stars 9 forks source link

Intellisense should trigger on the character after : #1

Closed Tyriar closed 7 years ago

Tyriar commented 7 years ago

Using : at the end of a paragraph will trigger the intellisense and insert the 👍 emoji instead of adding a new line. Instead I'd like the popup to appear automatically only on :+ for :+1:, not :.

mattbierner commented 7 years ago

Yes, I agree that the following cases should never auto trigger suggestions with you type the ::

a:|
a:| b

However for other cases such as:

:|
a :|
a :| b

I personally like having suggestions triggered without typing a first character. This is also how github inputs work.

For 0.1.0 I've tried to stop showing completions in those first set of cases. I've also added a showOnColon setting that disables automatic triggering on : altogether. If you do this, I recommend having quick suggestions enabled or else you have to manually trigger emoji suggestions while typing.


Looking into this issue, I ran into a few limitations of our current completion API, including:

Maybe I'm overlooking something simple here but I found that getting the trigger behavior that you described was way harder than it should have been, and the current implementation is still not correct