search

mattbierner / vscode-emojisense

Emoji Autocomplete Plugin For VSCode
https://marketplace.visualstudio.com/items?itemName=bierner.emojisense
MIT License
123 stars 9 forks source link

npm audit fix & add option to enable extension for ALL languages #14

Closed kiprasmel closed 5 years ago

kiprasmel commented 5 years ago

Hello, the feature of being able to just enable this extension for ALL languages would be very useful.

If I did everything correctly, this would fix https://github.com/mattbierner/vscode-emojisense/issues/10.

Also, if this were to be accepted - the docs would need an update too about the extra option.

Please provide additional information if there's anything I missed - I'm new to vscode's extension development.

Edit: This works on say .txt files, but it doesn't somehow in .js and many other files (the extension doesn't give you intellisense with available emojis; it gives the emoji only when you fully type it out but doesn't delete the :foo: code). Additional fixes are needed @mattbierner

mattbierner commented 5 years ago

To get completions workings, you also need to update the completion provider registration: https://github.com/mattbierner/vscode-emojisense/blob/afc8ce69d6bbb85a35d0ba029eeae914ca46a459/src/extension.ts#L12

I think you can pass * as the language identifier to register a completion provider for all languages.

mattbierner commented 5 years ago

Hey, saw you pushed a commit. Just checking in to see what you want to do with this PR? I think it is headed in the correct direction but needs a few changes

mattbierner commented 5 years ago

Closing this as out of date