search

mattbierner / vscode-emojisense

Emoji Autocomplete Plugin For VSCode
https://marketplace.visualstudio.com/items?itemName=bierner.emojisense
MIT License
123 stars 9 forks source link

Show emoji in completion list #2

Closed felixfbecker closed 7 years ago

felixfbecker commented 7 years ago

Everything is rendered in a Chrome renderer so VS Code should have no problem showing the actual unicode emoji in the completion list

felixfbecker commented 7 years ago

Just noticed it does get shown in the details section upon selection. How about showing it directly in the list like GH does?

mattbierner commented 7 years ago

I reverted d493cb2 for 0.2 because solutions that alters the label break the VSCode completion filtering logic. Reopening

felixfbecker commented 7 years ago

I think you can provide a different string to filter by than the label

mattbierner commented 7 years ago

Yes filterText but it actually doesn't work properly in my testing

svipas commented 7 years ago

I wanted to create an issue, but I think you're guys talking about the same. In @mattbierner example here https://marketplace.visualstudio.com/items?itemName=bierner.emojisense emojis is icons, but when I install and use it I see only unicode. This plugin can be really good if it shows actual image, not unicode. And by the way, nice work, really good plugin, I will try to use more emojis in my .MD :smile:

mattbierner commented 7 years ago

Just published 0.3.0 which includes this. Was fixed by 73bd946 with vscode 1.17+