Angular 2 port - Githubissues

mattdesl / audiograph.xyz

A visual exploration of Pilotpriest's 2016 album, TRANS.

Other

333 stars 40 forks source link

Angular 2 port #1

Closed atalw closed 8 years ago

atalw commented 8 years ago

Hey! Really like the visualization! I am building a music app and would like to use it if that is fine with you.

@NathanWalker has already converted it to an angular 2 component and could submit a pull request?

NathanWalker commented 8 years ago

@atalw @mattdesl My thoughts here would be to pay homage to the incredible talent that Matt is. If a PR were submitted that opened up the ability for others to integrate with the visualizer, my main questions would be:

should the audio player portion be refactored to be standalone so as to allow others to use their own audio player setup?
need a way to ensure all credit goes to Matt anytime the visualizer is used. some of this is handled by the console.log statement that is logged when the visualizer initializes. Another thought is that an embedded line in the visualizer which would display Matt's name with a link back to him, etc.

@atalw You should probably elaborate on what your target is with your application?

atalw commented 8 years ago

@NathanWalker @mattdesl The application that I am developing is a music based social network for the web, kind of like spotify but some additional features. It is a personal side project and I am working on it heavily at the moment.

In my opinion, the audio player should be pluggable into the visualizer, but it should also be easily removable. This should allow maximum possible applications for this plugin (if that is the aim).

I am more than happy to give credit where credit is due. Displaying the name + link at the bottom of the visualizer should not be a problem.

mattdesl commented 8 years ago

Hello, and thanks! :smile:

Audiograph is a digital art project meant to highlight the album TRANS by Pilotpriest. It was never envisioned as a generic music visualizer, and I have no plans to support new features or additional UI.

I open sourced the project with the hope that others would learn from the code and be better equipped to build their own (unique and original) visualizations. Clones of Audiograph and its design – albeit legal – is something I would rather not see.

The good news is that I write lots of MIT-licensed libraries, tools, and resources that you are free to remix/fork/clone/etc. These can be used to build your own visualizers. 🍻 Here's a few links:

Good luck!

atalw commented 8 years ago

Thanks!