search

mattermost-community / mattermost-plugin-solar-lottery

A tool somewhat similar to pager duty, allows to have rotations with magic "solar lottery" scheduling, or overrides.
Apache License 2.0
4 stars 10 forks source link

Add `/lotto shift leave` command #14

Closed levb closed 4 years ago

levb commented 4 years ago

Needs to "do the right" thing when removing a user from a started shift. It should error on removing from a finished shift.

FedjaVitko commented 4 years ago

I would love to work on this ticket, just need a little bit of time to wrap my head around what the plugin does. UPDATE: Should be able to finish it today.

@levb what do you mean exactly by the "right thing"? open => remove the users from the shift, tell all other users in that shift that users have been removed, notify the removed users started => remove the users from the shift, tell all other users in that shift that users have been removed, notify the removed users finished => don't remove the users, error out

jfrerich commented 4 years ago

Good to see you again, @TheoVitkovskiy! I've added myself as a reviewer on your PR and will provide feedback this week!