search

mattermost-community / mattermost-plugin-solar-lottery

A tool somewhat similar to pager duty, allows to have rotations with magic "solar lottery" scheduling, or overrides.
Apache License 2.0
4 stars 10 forks source link

update circleci #18

Closed jfrerich closed 4 years ago

jfrerich commented 4 years ago

Summary

This request is to complete the intake process for the Solar Lottery plugin.

One of the requirements is to update CI. The mattermost-plugin-starter-template seems old, and my assumption is that we would want to move toward the config.yml file from the Jira plugin.

jfrerich commented 4 years ago

I have only spent about an hour with the documentation and while I've got questions, it's probably best to just get some feedback so we can get the plugin intake finished.

Questions: 1) I couldn't find the plugin-ci: mattermost/plugin-ci@volatile orb. Where is that stored and how can I access it? 2) Is the Jira config.yml the golden config and should we update mattermost-plugin-starter-template and all other plugins?

Assumptions: 1) The config file will be common among plugin repos?

crspeller commented 4 years ago
  1. https://github.com/mattermost/circleci-orbs
  2. mattermost-plugin-starter-template is intentionally different since not every plugin will run under our CI system. mattermost-plugin-demo should be the golden master to copy.
jfrerich commented 4 years ago

@crspeller thanks for the link to the orbs. This config matches mattermost-plugin-demo and I have converted this from a draft PR to a normal PR for review.