mattermost-community / mattermost-plugin-webex

Apache License 2.0
13 stars 19 forks source link

access Webex site from client side #22

Open bbodenmiller opened 4 years ago

bbodenmiller commented 4 years ago

Many Mattermost servers are not allowed to access the outside internet by default. This plugin should support this and access Webex site from client side.

cpoile commented 4 years ago

@bbodenmiller This turns out to be how connections to webex work currently. The plugin generates a link and posts it in a message, and when a user clicks on the link in a message they connect directly to the webex system -- there's no traffic through the Mattermost instance during/after the link click.

Please let me know if I'm misunderstanding the issue?

bbodenmiller commented 4 years ago

I get that but is the sever or client connecting to Webex to generate the link in the first place? My sever isn't able to access any content on *.Webex.com.

On Thu, Jan 30, 2020, 6:31 AM Christopher Poile notifications@github.com wrote:

@bbodenmiller https://github.com/bbodenmiller This turns out to be how connections to webex work currently. The plugin generates a link and posts it in a message, and when a user clicks on the link in a message they connect directly to the webex system -- there's no traffic through the Mattermost instance during/after the link click.

Please let me know if I'm misunderstanding the issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mattermost/mattermost-plugin-webex/issues/22?email_source=notifications&email_token=AAJDGTD6XUUOIQ6HV53MZILRALQCTA5CNFSM4KLTCKZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKLF3AY#issuecomment-580279683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDGTF2NYBNAAQXIS34DZDRALQCTANCNFSM4KLTCKZQ .

levb commented 4 years ago

@bbodenmiller ACK. Historically, we focused on server-side and/or server-centric plugins; largely to enable functionality on mobile.

However, there's nothing really, at least in theory, preventing us from creating 100%-webapp plugins (well, serving them from the server). We should consider.

bbodenmiller commented 4 years ago

@levb right, I've found the Mattermost move towards more sever side connections when client side would be possible problematic. In security sensitive environments server connections to outside internet are more restricted (blocked entirely in many cases) than client side connections to outside internet.

cpoile commented 4 years ago

@levb We could have a back-up webex-client code on the front end. It would query the webex server for the room url given the meeting starter's preferred setting. I think it can be a HW.

levb commented 4 years ago

It is my understanding that the client was already not restricted and has no issue connecting to WebEx; the server (plugin!) must use a proxy though. Client can be configured separately anyway.

cpoile commented 4 years ago

You're right, the client can do the connection, but the client will need to respect the meeting starter's preferred way to find their meeting room URL (roomId, username/webexId, or email). Then the client can query the Webex server to get that URL.

We need to include that info in the meeting post (as props), then the client needs to have all the webex xml request settings to make the request (can be found in the server/webex package).