search

mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2.03k stars 830 forks source link

[MM-58089] Disallow redirects to untrusted URLs without a permission prompt #3024

Closed devinbinnie closed 6 months ago

devinbinnie commented 7 months ago

Summary

It's possible to allow a server to redirect to an external application without a permission prompt, so I've added the prompt to this PR.

Ticket Link

https://mattermost.atlassian.net/browse/MM-58089

Fixed an issue where a server could redirect to an external application without a prompt
devinbinnie commented 7 months ago

Thanks @devinbinnie! Should we include a test to cover that it would open the dialog for this new case we are covering here?

The existing tests should actually cover this case now as well so I think we're okay :)

mattermost-build commented 6 months ago

Cherry pick is scheduled.