search

mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2k stars 815 forks source link

[MM-58455] Add error handling when FocusStatus is not authorized on macOS #3053

Closed devinbinnie closed 4 months ago

devinbinnie commented 4 months ago

Summary

A recent change that allowed the macOS app to correctly use the FocusStatus to prevent notifications under DND was completely stopping notifications if permission wasn't given. This was caused by the app not performing any error handling from the DND check, which would throw an error if the app wasn't authorized to check the status.

This PR adds that error handling, and logs a warning in the logs to denote that the check failed.

Ticket Link

Closes https://github.com/mattermost/desktop/issues/3052 https://mattermost.atlassian.net/browse/MM-58455

Fixed an issue where notifications would not show on macOS in certain cases.
devinbinnie commented 4 months ago

@amyblais I'm looking to do a dot release for this one if possible.

amyblais commented 4 months ago

@amyblais I'm looking to do a dot release for this one if possible.

Ok 👍

mattermost-build commented 4 months ago

Cherry pick is scheduled.