Closed devinbinnie closed 5 months ago
Is this a recent regression or something that we tracked down with recent metrics and added logging? Can we create a ticket for tracking purposes on notification fixes?
I just found this while testing the notifications manually, but I can add a ticket for it.
Do we want to include this in the dot release as well?
cc @amyblais
Sounds good.
Cherry pick is scheduled.
Summary
Found a few issues with reporting notifications on Windows and a small bug that I wanted to fix:
show
andfailed
events when a notification fails to show due to permissions not being enabled for Mattermost in Windows. This was then always being reported as asuccess
when it should benot_sent
, so I had to add a timeout to have theshow
callback wait for thefailed
one to potentially run (not an elegant solution)failed
when the notification fails the permission check. This should now be reported asnot_sent
as it is a user choice not to send the notificationTicket Link
https://mattermost.atlassian.net/browse/MM-58693