mattermost / desktop

Mattermost Desktop application for Windows, Mac and Linux
Apache License 2.0
2.04k stars 831 forks source link

Mattermost is not starting maximized on autostart #419

Closed mikalehmann closed 7 years ago

mikalehmann commented 7 years ago

I confirm (by marking "x" in the [ ] below):


Summary Mattermost is starting as a non-maximized window, even if I maximize it before quitting. It should remember the state of the window over multiple sessions.

Information

Steps to reproduce

Expected behavior The Mattermost window is maximized. how it should be

Observed behavior It's not. It's nearly as big as my screen, but doesn't fill it completely. how it is

jasonblais commented 7 years ago

Thanks @Lehmax, confirmed on Windows 10 as well.

yuya-oc commented 7 years ago

Thanks, but it didn't reproduce for me on Windows 10. I tried with 2160p screen.

jasonblais commented 7 years ago

Hmm, it's not reproducing for me now either.. It definitely was earlier, so I'll keep an eye out for this.

@Lehmax does this reproduce for you every time when you quit, then re-open the app?

mikalehmann commented 7 years ago

Yes, it does. I can fix it temporarily by switching to 1080p, maximizing and then reverting the resolution. After I do that, it stays maximized even if I exit and restart Mattermost. If I log off from my Windows account or restart the PC, it's not maximized again.

@jasonblais what resolution are you on?

jasonblais commented 7 years ago

it's minimized again

Do you mean a) minimized when the app starts (i.e. minimized to taskbar), or b) opens in window size that isn't maximized?

mikalehmann commented 7 years ago

The latter. Nearly as big as my screen, but not maximized.

yuya-oc commented 7 years ago

@Lehmax After exiting from the app, what about %HOME%\AppData\Roaming\Mattermost\bounds-info.json? Maximized state should be saved in it.

mikalehmann commented 7 years ago

Any reference to "signing out" means signing out of my windows account to trigger autostart.

I just observed the bounds-info.json while doing different stuff. First it was set to false. Then I maximized the window and it changed to true. After exiting and restarting it stayed true. I signed out and opened Notepad++ immediately after logging in, but before Mattermost autostarted. It was still set to "true". After Mattermost autostarted it was "false" again until I maximized the window. It's strange that it now stays maximized after exiting, but still fails when signing out.

{"x":-8,"y":-8,"width":2560,"height":1400,"maximized":false,"fullscreen":false} This is my file, in case it helps. This is how it looks like after maximizing and triggering the autostart. It's also worth noting that resizing and exiting/signing out works. It will remember the size of the windows. Only after I maximize and sign out it will forget that it should be maximized by default.

yuya-oc commented 7 years ago

Thanks you for detailed information.

When using autostart, the application launches with --hidden flag. In this case, the maximized state was not restored. Would you confirm this build fixes the problem?

https://circleci.com/gh/yuya-oc/desktop/135#artifacts

mikalehmann commented 7 years ago

It does. 👍

yuya-oc commented 7 years ago

Thanks!