search

mattermost / docker

Install Mattermost server via Docker
Apache License 2.0
338 stars 209 forks source link

Fix OOM (Out Of Memory) Errors #138

Open mjnaderi opened 1 year ago

mjnaderi commented 1 year ago

Summary

This PR fixes https://github.com/mattermost/mattermost/issues/20625.

Ticket Link

None

mvitale1989 commented 11 months ago

Thank you for your contribution @mjnaderi ! I don't have an objection to this change myself, but I don't think this fixes https://github.com/mattermost/mattermost/issues/20625 , since the reporter mentions using Openshift, so they are unlikely to be using docker compose. I would include @agnivade as a reviewer, to double check if there are conditions under which such a spike in PIDs in the Mattermost container is expected.

mvitale1989 commented 11 months ago

Thanks for the input Agniva! Agreed, if more than 200 PIDs is an unreasonable number then we'd better understand what that is first before thinking about merging this change. I'll remove my approval for the time being to reduce confusion

erfantkerfan commented 6 months ago

I had the same problem and changing this values fixed it. Like you said, I pushed the problem under the rug by increasing the limit.

agnivade commented 6 months ago

Did you try listing out the processes to see what was wrong?

erfantkerfan commented 6 months ago

Did you try listing out the processes to see what was wrong?

No, but since then, I did not have any crashes, so I did not have the chance to