When a user assigns a merge request to another user before creating the merge request, the assignee gets a notification of requested review instead of assigned merge request.
Steps to reproduce
Start creating a merge request on GtiLab.
Before creating a merge request, add an assignee to the merge request.
Create the merge request.
Check the notification received on the Mattermost.
Expected behaviour
Should show notification for assignment of the merge request
Actual behaviour
Notification received for the review request on the merge request
Additional context
This might be due to the fact that we are simply showing requested your review at line instead of checking whether the notification was for assignment of merge request or due to request review.
ayusht2810
commented
4 months ago
Description
When a user assigns a merge request to another user before creating the merge request, the assignee gets a notification of
requested reviewinstead ofassigned merge request.Steps to reproduce
Expected behaviour
Should show notification for assignment of the merge request
Actual behaviour
Notification received for the review request on the merge request
Additional context
This might be due to the fact that we are simply showing
requested your reviewat line instead of checking whether the notification was forassignment of merge requestor due torequest review.