mattermost / mattermost-plugin-gitlab

GitLab plugin for Mattermost
Apache License 2.0
141 stars 85 forks source link

Added a message to create a subscription after running the pipeline (#341) #445

Closed avas27JTG closed 10 months ago

avas27JTG commented 10 months ago

Summary

Added a message to create a subscription after running the pipeline (#341)

Screenshot

Ticket Link

Fixes #341

codecov[bot] commented 10 months ago

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (ee780c1) 33.40% compared to head (ef80e1d) 33.21%.

Files Patch % Lines
server/command.go 0.00% 22 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #445 +/- ## ========================================== - Coverage 33.40% 33.21% -0.19% ========================================== Files 22 22 Lines 3979 4001 +22 ========================================== Hits 1329 1329 - Misses 2519 2541 +22 Partials 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 10 months ago

I think this is already implemented here right? https://github.com/mattermost/mattermost-plugin-gitlab/pull/433

raghavaggarwal2308 commented 10 months ago

@mickmister I think there was some confusion here. We can close this PR and continue with #433 as that is already in the review process.