search

mattermost / mattermost-plugin-google-calendar

Mattermost Google Calendar Plugin
33 stars 31 forks source link

[MM-73]: Fixed the issue of getting invalid start/end time even though they were set #79

Closed Kshitij-Katiyar closed 1 month ago

Kshitij-Katiyar commented 1 month ago

Summary

The start/end time was auto-selected when we opened the modal to create an event but still got the error that they were invalid. So fixed it by removing the autoselected value.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-google-calendar/issues/73

Ticket Link

1) Run /gcal event create 2) Update the subject and click on submit, the meeting should be created.

mickmister commented 1 month ago

Alternatively we could have the initial/default value be given by the parent component. If the UX flow for the empty value seems fine then we can keep that solution

Edit: I didn't mean to close the PR

mickmister commented 1 month ago

@matthewbirtch When the "create event" modal is opened, what value should be shown in the "end time" date selector initially? Should be filled (e.g. with the current date), or be left blank?

matthewbirtch commented 1 month ago

@matthewbirtch When the "create event" modal is opened, what value should be shown in the "end time" date selector initially? Should be filled (e.g. with the current date), or be left blank?

@mickmister the default end time should be 30 minutes from the default start time.

wiggin77 commented 1 month ago

@Kshitij-Katiyar @fmartingr customer is asking for an update on when this fix will be delivered. Please advise.

Kshitij-Katiyar commented 1 month ago

@Kshitij-Katiyar @fmartingr customer is asking for an update on when this fix will be delivered. Please advise.

@wiggin77 We are working on this. Only the QA review is left here.

fmartingr commented 1 month ago

@Kshitij-Katiyar @fmartingr customer is asking for an update on when this fix will be delivered. Please advise.

@wiggin77 We are working on this. Only the QA review is left here.

Can you provide an estimate on when QA is going to be completed/take place?