mattgodbolt / jsbeeb

Javascript BBC micro emulator
GNU General Public License v3.0
351 stars 68 forks source link

CORS error when trying to load disk image from github #430

Closed LoveBug2084 closed 3 months ago

LoveBug2084 commented 3 months ago

I get a CORS error with jsbeeb running on my site when trying to load my LadyBug project disk image from github

https://lovebyte.eu.org/jsbeeb-main/?autoboot&noseek&disc=https://github.com/LoveBug2084/LadyBug/raw/main/src/Lady%20Bug.ssd

This use to work fine but now causes an error with the latest LibreWolf (firefox) browser update

Is this an actual issue or is it just me not knowing what im doing :rofl:

mattgodbolt commented 3 months ago

It's not in general possible to grab things from the github.com domain by design - like github on purposes prevents CORS to stop e.g. jsbeeb reading content as you because youre logged into gitbhu.

However the "raw" link of github (on githubusercontent or whatever) should work -

https://lovebyte.eu.org/jsbeeb-main/?autoboot&noseek&disc=https://raw.githubusercontent.com/LoveBug2084/LadyBug/main/src/Lady%20Bug.ssd

should work

mattgodbolt commented 3 months ago

your jsbeeb seems down right now but here it is working ok on the main site: https://bbc.xania.org/?disc=https://raw.githubusercontent.com/LoveBug2084/LadyBug/main/src/Lady%20Bug.ssd

mattgodbolt commented 3 months ago

please reopen if you have any problems :)

LoveBug2084 commented 3 months ago

oh it was a user error then sorry what threw me was that it used to work until I updated my browser

thanks for your help

hosting had issues just for 30 mins, my site is back up now

cheers :beer::beer::beer::beer::beer:

mattgodbolt commented 3 months ago

No problem at all! I wonder if the prior browser wasn't "doing it properly" as there's nothing jsbeeb can do to control what the browser or github does :)

The disc image looks very cool btw!

LoveBug2084 commented 3 months ago

thanks, its a fun game but not as cool as your emulator

amazing work :star::star::star::star::star: