mattgodbolt / owlet-editor

A modern BBC BASIC editor inspired by the BBC Micro Bot (https://bbcmicrobot.com)
https://bbcmic.ro
54 stars 4 forks source link

Reset state after line number token #74

Closed ojwb closed 3 years ago

ojwb commented 3 years ago

(I noticed just after pushing that someone else had opened an issue for this, so I've added a "Fixes" reference to the commit message and force pushed.)

ojwb commented 3 years ago

Is there anything I can do to help get this merged?

Ignoring the auto-reformatting commit (those changes were forced upon me by a git hook) this is a single line fix plus regression test which solves an annoying bug multiple people have run in to (it's been brought up on twitter a few times, as well as the issue reported here).

ojwb commented 3 years ago

I've pushed a commit which supresses the undesirable expansion of line number tokens inside strings, as demonstrated by this example:

https://twitter.com/P_Malin/status/1441075916545970184

mattgodbolt commented 3 years ago

hey hey! wow, sorry !!!! I'll take a look right now :blush: